[mlir][cmake] Fix mlir target export #153341
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-mlir Author: Boyana Norris (brnorris03) ChangesIn #152195, target export was accidentally moved inside a conditional, but it should have been left outside. This patch undoes that change. Full diff: https://github.com/llvm/llvm-project/pull/153341.diff 1 Files Affected:
diff --git a/mlir/cmake/modules/AddMLIR.cmake b/mlir/cmake/modules/AddMLIR.cmake
index 14eefb50ca714..38839679ef8b1 100644
--- a/mlir/cmake/modules/AddMLIR.cmake
+++ b/mlir/cmake/modules/AddMLIR.cmake
@@ -641,8 +641,8 @@ function(add_mlir_library_install name)
COMPONENT ${name})
endif()
set_property(GLOBAL APPEND PROPERTY MLIR_ALL_LIBS ${name})
- set_property(GLOBAL APPEND PROPERTY MLIR_EXPORTS ${name})
endif()
+ set_property(GLOBAL APPEND PROPERTY MLIR_EXPORTS ${name})
endfunction()
# Declare an mlir library which is part of the public C-API.
|
|
@christopherbate This undoes an accidental move of the target export line, which was merged with #152195 (sorry about that!). |
|
As I said in the original PR, this fixes our build issue, so LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #152195, target export was accidentally moved inside a conditional, but it should have been left outside. This patch undoes that change.